Makefile: add debug symbols to loki and promtail debug builds #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed `-s` and `-w` flags of go compiler `--ldflags` from GO_LDFLAGS, cleaning up DEBUG_GO_LDFLAGS to have debug info removed. Also pushed the removed flags into GO_FLAGS `--ldflags` to remove debug info from release binaries.
|
|
sh0rez
approved these changes
Nov 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
removed
-sand-wflags of go compiler--ldflagsfromGO_LDFLAGS, cleaning up DEBUG_GO_LDFLAGS allowing to
have debug info enabled in debug builds.
Also pushed the removed flags into GO_FLAGS
--ldflagsto remove debuginfo from release binaries.
Which issue(s) this PR fixes:
Fixes #1338
Special notes for your reviewer:
Checklist