feat: Add metrics for Ingester RF-1 #13510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
reviewed
Jul 12, 2024
grobinson-grafana
force-pushed
the
grobinson/add-metrics
branch
from
29bee3f to
7208d9c
Compare
benclive
approved these changes
Jul 16, 2024
| @@ -262,6 +279,8 @@ func (b *SegmentWriter) WriteTo(w io.Writer) (int64, error) { | |||
| } | |||
| total += int64(n) | |||
|
|
|||
| b.outputSize.Store(total) | |||
| i.metrics.chunksFlushFailures.Inc() | ||
| i.metrics.flushesTotal.Add(1) | ||
| if err := i.store.PutObject(ctx, fmt.Sprintf("loki-v2/wal/anon/"+id.String()), r); err != nil { | ||
| i.metrics.flushFailuresTotal.Inc() | ||
| return fmt.Errorf("store put chunk: %w", err) |
There was a problem hiding this comment.
not related to your PR but we should change this error message to "segment" to avoid confusion if it ever appears.
| } | ||
| b.metrics.tenants.Observe(float64(len(tenants))) | ||
| b.metrics.inputSizeBytes.Observe(float64(b.inputSize.Load())) | ||
| b.metrics.outputSizeBytes.Observe(float64(b.outputSize.Load())) |
There was a problem hiding this comment.
Maybe we should only observe the output bytes if we've set a value here? In case we call Observe only after writing to the segment but haven't compressed/read it yet.
There was a problem hiding this comment.
Yeah! I was also thinking of documenting that Observe should be called after it has written the output, but idk?
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull requests adds a number of initial metrics for Ingester RF-1.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR