Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(structured-metadata-api): add structured metadata to /detected_fields API #13604

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

svennergr
Copy link
Contributor

What this PR does / why we need it:

Followup of #13119. This PR adds structured metadata to the response of /detected_fields call. Structured metadata will be identified by an empty parsers array.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@svennergr svennergr requested a review from a team as a code owner July 22, 2024 09:53
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

parseDetectedFields needs a big refactoring it should only need the iterator to detect fields and not stream.

cc @trevorwhitney so many allocations ! This does diminish the benefits of using a sketch.

@cyriltovena cyriltovena merged commit ce02cc2 into main Jul 22, 2024
61 checks passed
@cyriltovena cyriltovena deleted the svennergr/detected-fields-structured-metadata branch July 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants