Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k212] fix: Keep blocks referenced by newer metas #13627

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

salvacorts
Copy link
Contributor

Backport 784e7d5 from #13614


What this PR does / why we need it:

This PR prevents the planner from deleting blocks from a outdated meta that is still referenced by an up to date meta.

Which issue(s) this PR fixes:
Fixes #13612

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts added size/L backport type/bug Somehing is not working as expected feature/blooms labels Jul 23, 2024
@salvacorts salvacorts requested a review from a team as a code owner July 23, 2024 10:30
@salvacorts salvacorts merged commit 182165a into k212 Jul 23, 2024
65 checks passed
@salvacorts salvacorts deleted the backport-13614-to-k212 branch July 23, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport feature/blooms size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants