Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): align image pull secrets usage #13635

Closed
wants to merge 1 commit into from

Conversation

sebhoss
Copy link
Contributor

@sebhoss sebhoss commented Jul 24, 2024

This assumes that users specify pull secrets like this in their values.yaml:

imagePullSecrets:
  - name: some-name-here

Most workloads in this helm chart already expect this to happen anyway. Those workloads that did not expect this were changed to keep the number of user facing breaking changes minimal.

What this PR does / why we need it:

The helm chart is currently inconsistent wrt. its usage of pull secrets. Sometimes it expects just an array of strings, sometimes a list of maps. This change alignes every pull secret reference to expect a list of maps. This was chosen because most workloads already expected this format and it is more future proof(tm) if https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/local-object-reference/#LocalObjectReference ever changes.

Which issue(s) this PR fixes:

This fixes an issue introduced with #13051 (comment) and extends what has happened in #13761

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@sebhoss sebhoss requested a review from a team as a code owner July 24, 2024 05:32
@sebhoss
Copy link
Contributor Author

sebhoss commented Jul 24, 2024

The test failure seems to be due to #13633 ?

@JStickler
Copy link
Contributor

JStickler commented Jul 24, 2024

@sebhoss #13651 should have fixed your test issue due to #13633.

@sebhoss
Copy link
Contributor Author

sebhoss commented Jul 24, 2024

Thanks, I'll rebase and adjust the changelog/chart

@sebhoss sebhoss force-pushed the pull-secret-alignment branch from c9fc02d to 97c1dca Compare July 26, 2024 05:12
@sebhoss
Copy link
Contributor Author

sebhoss commented Jul 26, 2024

@JStickler I think this is good to go now & sorry for the delay!

@sebhoss sebhoss force-pushed the pull-secret-alignment branch from 97c1dca to 3bf5e95 Compare July 26, 2024 09:11
@sebhoss
Copy link
Contributor Author

sebhoss commented Jul 26, 2024

Rebased on latest main

@sebhoss
Copy link
Contributor Author

sebhoss commented Jul 26, 2024

The test failure in pkg/ruler/base TestRuler_GetRulesLabelFilter seems unrelated to this PR

@sebhoss sebhoss force-pushed the pull-secret-alignment branch from 3bf5e95 to 2c6427d Compare July 31, 2024 12:05
@sebhoss
Copy link
Contributor Author

sebhoss commented Jul 31, 2024

Rebased on latest main

Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
@sebhoss sebhoss force-pushed the pull-secret-alignment branch from 2c6427d to 5e4e2ff Compare August 6, 2024 03:05
@pull-request-size pull-request-size bot added size/S and removed size/M labels Aug 6, 2024
@sebhoss
Copy link
Contributor Author

sebhoss commented Aug 6, 2024

rebased on latest main

@sebhoss
Copy link
Contributor Author

sebhoss commented Aug 6, 2024

@JStickler & @MasslessParticle can you take another look?

@sebhoss
Copy link
Contributor Author

sebhoss commented Aug 7, 2024

OK thanks - fixed with #13788

@sebhoss sebhoss closed this Aug 7, 2024
@sebhoss sebhoss deleted the pull-secret-alignment branch August 7, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants