Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helm): fix comment in values.yml #13638

Merged
merged 4 commits into from
Jul 25, 2024
Merged

chore(helm): fix comment in values.yml #13638

merged 4 commits into from
Jul 25, 2024

Conversation

AleksaC
Copy link
Contributor

@AleksaC AleksaC commented Jul 24, 2024

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@AleksaC AleksaC requested a review from a team as a code owner July 24, 2024 09:50
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

JStickler
JStickler approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler
Copy link
Contributor

Please generate Helm Chart reference by running 'make -C docs sources/setup/install/helm/reference.md'

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 24, 2024
@JStickler JStickler merged commit 250f4cf into grafana:main Jul 25, 2024
64 checks passed
benclive pushed a commit to cyriltovena/loki that referenced this pull request Jul 31, 2024
@AleksaC @JStickler @benclive
chore(helm): fix comment in values.yml (grafana#13638)
75730ce 
Co-authored-by: J Stickler <julie.stickler@grafana.com>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@AleksaC @JStickler
chore(helm): fix comment in values.yml (grafana#13638)
8006b21 
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
area/helm size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AleksaC @CLAassistant @JStickler