Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(detected-labels): remove cardinality filter #13652

Merged
merged 1 commit into from
Jul 24, 2024
+1 −3
Merged

feat(detected-labels): remove cardinality filter #13652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/querier/queryrange/roundtrip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,7 @@ func NewDetectedLabelsCardinalityFilter(rt queryrangebase.Handler) queryrangebas
var result []*logproto.DetectedLabel

for _, dl := range resp.Response.DetectedLabels {
if dl.Cardinality > 1 && dl.Cardinality < 50 {
result = append(result, &logproto.DetectedLabel{Label: dl.Label, Cardinality: dl.Cardinality})
}
result = append(result, &logproto.DetectedLabel{Label: dl.Label, Cardinality: dl.Cardinality})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, though if it were a request parameter it would give us more flexibility to find the right balance in the future. But, let's nuke it for now and see if it becomes a problem.

}
return &DetectedLabelsResponse{
Response: &logproto.DetectedLabelsResponse{DetectedLabels: result},
Expand Down
Loading