Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): admin-api should only be deployed in microservice mode #13655

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bradleypettit
Copy link
Contributor

@bradleypettit bradleypettit commented Jul 25, 2024

What this PR does / why we need it:
Enterprise deployments using SSD are expected to use the admin-api service within the backend pods. After the helm chart received support for microservice mode, a seperate admin-api deployment is created in both SSD and Microservice modes.

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:
n/a

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Bradley Pettit <12028233+bradleypettit@users.noreply.github.com>
@bradleypettit bradleypettit requested a review from a team as a code owner July 25, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant