fix: Return error 422 (Unprocessable Content) when push request does not contain any streams #13706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ravishankar15
force-pushed
the
validation-error-fix
branch
2 times, most recently
from
ed20552 to
222564b
Compare
|
Can someone take a look at this PR its a small fix |
ravishankar15
force-pushed
the
validation-error-fix
branch
from
222564b to
7aee9a6
Compare
chaudum
changed the title
chaudum
reviewed
Nov 29, 2024
pkg/validation/validate.go
Outdated
| @@ -11,7 +11,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| ReasonLabel = "reason" | |||
| ReasonLabel = "reason" | |||
| MissingStreams = "error at least one valid stream is required for ingestion" | |||
There was a problem hiding this comment.
nit: I would use the same naming convention as for other error messages
Suggested change
| MissingStreams = "error at least one valid stream is required for ingestion" | |
| MissingStreamsErrorMsg = "error at least one valid stream is required for ingestion" |
ravishankar15
force-pushed
the
validation-error-fix
branch
from
7aee9a6 to
9ff4612
Compare
chaudum
approved these changes
Dec 13, 2024
This was referenced Dec 23, 2024
mveitas
pushed a commit
to mveitas/loki
that referenced
this pull request
Jan 6, 2025
…not contain any streams (grafana#13706)
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #13399
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR