pkg/logentry/stages: Stage must call next stage to continue processing #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage can now decide whether processing should continue or not by calling or not calling next stage in the chain. This allows implementing more complex stages, eg. multiline stage. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Don't use new pipelineChain for each stage, reuse existing one. Don't call time.Since if not needed. Don't allocate new resultChain for each benchmark iteration. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
mattmendick
added
the
keepalive
stale
bot
removed
the
stale
|
Closing in favor of #1380, which contains this already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage can now decide whether processing should continue or not by
calling or not calling next stage in the chain.
This allows implementing more complex stages, eg. multiline stage.
This is just a proof of concept to show the idea of stage chains.