Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dskit 20240819 #13924

Merged
merged 3 commits into from
Aug 19, 2024
Merged

chore(deps): update dskit 20240819 #13924

merged 3 commits into from
Aug 19, 2024

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Aug 19, 2024

What this PR does / why we need it:
New version of DSKit introduces new function signatures for ring.AddListener. This is to accommodate that support. The nightly GEL build has failed due to this signature not existing, since it is on a newer dskit.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

paul1r added 2 commits August 19, 2024 09:32

Verified

This commit was signed with the committer’s verified signature.
paul1r Paul Rogers

Verified

This commit was signed with the committer’s verified signature.
paul1r Paul Rogers
@paul1r paul1r requested a review from a team as a code owner August 19, 2024 14:12

Verified

This commit was signed with the committer’s verified signature.
paul1r Paul Rogers
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Aug 19, 2024
Copy link
Contributor

@vlad-diachenko vlad-diachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@paul1r paul1r merged commit 8fb7b48 into main Aug 19, 2024
63 checks passed
@paul1r paul1r deleted the paul1r/update_dskit_20240819 branch August 19, 2024 15:01
paul1r added a commit that referenced this pull request Aug 19, 2024

Verified

This commit was signed with the committer’s verified signature.
paul1r Paul Rogers
paul1r added a commit that referenced this pull request Aug 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants