Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement WAL segment ingestion via Kafka with partition ring #14043

Merged
merged 16 commits into from
Sep 10, 2024

Conversation

cyriltovena
Copy link
Contributor

@cyriltovena cyriltovena commented Sep 4, 2024

  • Set up Kafka consumer for WAL segments
  • Implement partition ring for managing assignments
  • Add delayed downscale endpoint for graceful partition consumption
  • Implement 15s block building and flushing to metastore/object storage
  • First pass on the encoding/decoding of push request to Kafka

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

- Set up Kafka consumer for WAL segments
- Implement partition ring for managing assignments
- Add delayed downscale endpoint for graceful partition consumption
- Implement 10s block building and flushing to metastore/object storage
- First pass on the encoding/decoding of push request to Kafka
@github-actions github-actions bot added type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories and removed size/XXL labels Sep 4, 2024
@cyriltovena cyriltovena changed the title WIP: Implement WAL segment ingestion via Kafka with partition ring feat: Implement WAL segment ingestion via Kafka with partition ring Sep 5, 2024
@cyriltovena cyriltovena marked this pull request as ready for review September 5, 2024 10:04
@cyriltovena cyriltovena requested a review from a team as a code owner September 5, 2024 10:04
pkg/kafka/encoding.go Show resolved Hide resolved
pkg/kafka/encoding.go Show resolved Hide resolved
pkg/kafka/encoding.go Outdated Show resolved Hide resolved
pkg/kafka/ingester/metrics.go Outdated Show resolved Hide resolved
}

// Flush writes the accumulated data to storage and updates the metadata store
func (c *consumer) Flush(ctx context.Context) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a check for input size so we don't write empty blocks.

 // Flush writes the accumulated data to storage and updates the metadata store
 func (c *consumer) Flush(ctx context.Context) error {
+       if c.writer.InputSize() == 0 {
+               return nil
+       }
+
        start := time.Now()
        c.metrics.flushesTotal.Add(1)
        defer func() { c.metrics.flushDuration.Observe(time.Since(start).Seconds()) }()

@cyriltovena cyriltovena merged commit d178f4c into grafana:main Sep 10, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants