allow configuring a target chunk size in compressed bytes #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Welch <edward.welch@grafana.com>
rfratto
reviewed
Dec 12, 2019
docs/configuration/README.md
Outdated
| @@ -267,8 +267,16 @@ The `ingester_config` block configures Ingesters. | |||
| # period as long as they receieve no further activity. | |||
| [chunk_idle_period: <duration> | default = 30m] | |||
|
|
|||
| # The maximum size in bytes a chunk can be before it should be flushed. | |||
| # The maximum _uncompressed_ size in bytes of a chunk block, | |||
There was a problem hiding this comment.
I don't think this is 100% accurate: almost all blocks are going to end up being greater than this size. This is more like the cuttoff point for when an uncompressed block should be compressed.
Do you think it's worth explaining that in the docs?
There was a problem hiding this comment.
yeah agree, will reword this
There was a problem hiding this comment.
@rfratto reworded, let me know what you think
There was a problem hiding this comment.
Nice, this is more clear. Thanks!
cyriltovena
reviewed
Dec 12, 2019
cyriltovena
reviewed
Dec 12, 2019
Signed-off-by: Edward Welch <edward.welch@grafana.com>
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
Limiting chunks query start time with config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to figure out still what to do with the error if you fail to cut a chunk...
Signed-off-by: Edward Welch edward.welch@grafana.com