Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Linting updates in prep for Go 1.23 #14071

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Sep 6, 2024

What this PR does / why we need it:
This PR is in preparation for a move to Go 1.23. It does some linting cleanup of the Loki codebase, getting the large majority of the issues. Items that were deemed more aggressive (e.g. issues with reflect.SliceHeader and reflect.StringHeader were left out of this batch of changes).
Golang 1.23 prefers golangci-lint 1.60.3+, which is more aggressive in identifying linting errors.

The majority of these fixes are in relation to:


  • Unused parameters (changed to _)
  • printf: non-constant format string (changed to include a "%s")
  • var-naming, for private functions/variables that were fooIdsBar, they are now fooIDsBar
    Which issue(s) this PR fixes:
    Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner September 6, 2024 16:14
@paul1r paul1r merged commit 18cef21 into main Sep 6, 2024
61 checks passed
@paul1r paul1r deleted the paul1r/go_1_23_linter_updates branch September 6, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants