Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blooms): Replace extracting line filters with extracting label filters #14137

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Sep 13, 2024

What this PR does / why we need it:

Replace the logic for extracting line filters with extracting label filters on the bloom gateway client, because otherwise the bloom gateway server would receive requests with no label matchers.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum requested a review from a team as a code owner September 13, 2024 17:13
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/replace-extract-linefilters branch from 8787c2c to f8bcb3d Compare September 13, 2024 17:18
@chaudum chaudum merged commit 5bffc10 into main Sep 13, 2024
61 checks passed
@chaudum chaudum deleted the chaudum/replace-extract-linefilters branch September 13, 2024 18:19
@emadolsky
Copy link
Contributor

Hi! This doesn't seem right. Or at least the document should be updated that line filters are not being considered for bloom filtering:

- The filtering expression contains at least as many characters as the n-gram length used to build the blooms.
- For example, if the n-grams length is 5, the filter `|= "foo"` will not take advantage of blooms but `|= "foobar"` would.

Or maybe I'm getting this wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants