fix: show 200 status code for successful queries #14175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
commented
Sep 18, 2024
| @@ -18,9 +18,6 @@ common: | |||
| kvstore: | |||
| store: inmemory | |||
|
|
|||
| ingester_rf1: | |||
There was a problem hiding this comment.
this appears to have been removed from the code, but was not removed from the config? I got an error on main when trying to use this config.
ashwanthgoli
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
LGTM
i opened up a similar pr a while back, but failed to merge it. I'll close it once this is merged.
|
@ashwanthgoli I like yours better, closing in favor of #12102 |
|
nevermind, we still need it in |
|
nevermind again, I can't read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change in #10956 broke the status code reporting in the
metrics.goline from our queriers. In the case where error wasnil, it produces a 500. Previously, when error was nil, it produced a 200.This PR fixes that behavior, reporting a 200 status unless there is a problem.