Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release workflow needs to use the GH App token #14193

Merged
merged 5 commits into from
Sep 20, 2024
Merged

ci: release workflow needs to use the GH App token #14193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30dd6e3
ci: release workflow needs to use the GH App token
trevorwhitney Sep 19, 2024
02fa638
ci: ignore whitespace when checking workflow diff
trevorwhitney Sep 19, 2024
6260e20
fix: remove whitesapce changes
trevorwhitney Sep 19, 2024
0d32c1e
Merge branch 'main' into release-needs-to-use-gh-token
trevorwhitney Sep 19, 2024
eb617fd
Merge branch 'main' into release-needs-to-use-gh-token
trevorwhitney Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/release-workflows.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ local imagePrefix = 'grafana';
imagePrefix='grafana',
releaseLibRef=releaseLibRef,
releaseRepo='grafana/loki',
useGitHubAppToken=false,
useGitHubAppToken=true,
), false, false
),
'check.yml': std.manifestYamlDoc({
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ env:
PUBLISH_TO_GCS: false
RELEASE_LIB_REF: "main"
RELEASE_REPO: "grafana/loki"
USE_GITHUB_APP_TOKEN: false
USE_GITHUB_APP_TOKEN: true
jobs:
createRelease:
if: "${{ fromJSON(needs.shouldRelease.outputs.shouldRelease) }}"
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,5 +915,5 @@ ifeq ($(BUILD_IN_CONTAINER),true)
else
@$(MAKE) release-workflows
@echo "Checking diff"
@git diff --exit-code -- ".github/workflows/*release*" || (echo "Please build release workflows by running 'make release-workflows'" && false)
@git diff --exit-code --ignore-space-at-eol -- ".github/workflows/*release*" || (echo "Please build release workflows by running 'make release-workflows'" && false)
endif
Loading