Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove usage of unsafe string in label adapter unmarshal #14216

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Sep 23, 2024

What this PR does / why we need it:

Unmarshal method of LabelAdapter was using yoloString to reference parts of a bytes buffer alloced by grpc lib.
But with release 1.66.0, grpc introduces a new codec that reuses buffers. Referencing parts of these buffers is not safe anymore since these bytes could get cleared or replaced by other messages.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli changed the title Label adapter remove unsafestr fix: remove usage of unsafe string in label adapter unmarshal Sep 23, 2024
@ashwanthgoli ashwanthgoli force-pushed the label-adapter-remove-unsafestr branch from 41fb285 to ed75a93 Compare September 23, 2024 09:56
@ashwanthgoli ashwanthgoli marked this pull request as ready for review September 23, 2024 09:57
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner September 23, 2024 09:57
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should close #14053

@ashwanthgoli ashwanthgoli merged commit 758364c into main Sep 24, 2024
62 checks passed
@ashwanthgoli ashwanthgoli deleted the label-adapter-remove-unsafestr branch September 24, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants