fix(operator): Add missing groupBy label for all rules on OpenShift #14279
+140
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
added a commit
to periklis/loki
that referenced
this pull request
Sep 30, 2024
periklis
added a commit
to periklis/loki
that referenced
this pull request
Sep 30, 2024
periklis
added a commit
to periklis/loki
that referenced
this pull request
Sep 30, 2024
periklis
added a commit
to periklis/loki
that referenced
this pull request
Sep 30, 2024
periklis
added a commit
to openshift/loki
that referenced
this pull request
Sep 30, 2024
[release-6.0] Backport PR grafana#14279
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 1, 2024
[release-5.9] Backport PR grafana#14279
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Routing of alerts in OCP managed Alertmanager instances requires all rules to be grouped by namespace. This fix renders in general all rule types to include the label by default.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR