Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage/chunk/client/aws): have GetObject check for canceled context (backport k223) #14423

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Oct 8, 2024

Backport 5f325aa from #14420


What this PR does / why we need it:

S3ObjectClient.GetObject incorrectly returned nil, 0, nil when the provided context is already canceled.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner October 8, 2024 13:00
@loki-gh-app loki-gh-app bot added backport size/S type/bug Somehing is not working as expected labels Oct 8, 2024
@loki-gh-app loki-gh-app bot requested a review from rfratto October 8, 2024 13:00
@rfratto rfratto merged commit 901525e into k223 Oct 8, 2024
66 checks passed
@rfratto rfratto deleted the backport-14420-to-k223 branch October 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant