chore: Add new field to "stats-report" log line in bloom gateway #14446
Conversation
This new field reports how many blocks have been proceesed in total in the multiplexed request. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
| @@ -83,6 +83,7 @@ func (p *processor) processTasksForDay(ctx context.Context, _ string, _ config.D | |||
|
|
|||
| for _, t := range tasks { | |||
| FromContext(t.ctx).AddBlocksFetchTime(duration) | |||
| FromContext(t.ctx).AddProcessedBlocksTotal(len(tasksByBlock)) | |||
There was a problem hiding this comment.
Just making sure this is correct: each task has exactly len(tasksByBlock) blocks?
There was a problem hiding this comment.
No, len(tasksByBlock) is the number of all blocks from multiple multiplexed requests.
There is another field Stats.ProcessedBlocks, which references the amount of blocks processed for the specific request (task).
There was a problem hiding this comment.
Hm, I'm not sure I understand why we're adding len(tasksByBlock) for each task then
There was a problem hiding this comment.
To see how many blocks are processed in a multiplexed request.
This is interesting for the -bloom-gateway.block-query-concurrency setting, which defines how many blocks are processed in parallel (as part of a multiplexed request).
chaudum
deleted the
chaudum/add-total-blocks-processed-to-bloom-gw-stats-log
branch
What this PR does / why we need it:
This new field reports how many blocks have been processed in total in the multiplexed request.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR