Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always write detected_level when enabled, even if unknown #14464

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Some aggregated metric lines are missing detected_level because when level is unknown we don't write detected_level to structured metadata. This PR offers a different approach to fix this than #14463, and it is to always write detected_level structured metadata when level detection is enabled, even if it's unknown.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner October 11, 2024 16:49
Copy link
Contributor

@shantanualsi shantanualsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@trevorwhitney trevorwhitney merged commit 41c6b6c into main Oct 15, 2024
60 checks passed
@trevorwhitney trevorwhitney deleted the fix-detected-level-in-agg-metrics-2 branch October 15, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants