Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct typo in TSDB migration doc #14554

Merged
merged 2 commits into from
Oct 21, 2024
Merged

docs: correct typo in TSDB migration doc #14554

merged 2 commits into from
Oct 21, 2024

Conversation

josemaia
Copy link
Contributor

What this PR does / why we need it:
Fixes a small typo in the TSDB migration doc.

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@josemaia josemaia requested a review from a team as a code owner October 21, 2024 13:14
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 21, 2024
JStickler
JStickler approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Thanks for taking the time to update the docs!

@JStickler
Copy link
Contributor

@josemaia Please sign the CLA so that I can merge this.

@josemaia
Copy link
Contributor Author

@josemaia Please sign the CLA so that I can merge this.

done, thanks

@JStickler JStickler merged commit 15a83b9 into grafana:main Oct 21, 2024
61 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Oct 21, 2024
@josemaia @grafana-delivery-bot
docs: correct typo in TSDB migration doc (#14554)
0b3439a 
(cherry picked from commit 15a83b9)
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 21, 2024
Merged
6 tasks
loki-gh-app bot pushed a commit that referenced this pull request Oct 21, 2024
@josemaia @grafana-delivery-bot
docs: correct typo in TSDB migration doc (#14554)
33c257a 
(cherry picked from commit 15a83b9)
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 21, 2024
Merged
6 tasks
loki-gh-app bot pushed a commit that referenced this pull request Oct 21, 2024
@josemaia @grafana-delivery-bot
docs: correct typo in TSDB migration doc (#14554)
a239679 
(cherry picked from commit 15a83b9)
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 21, 2024
Merged
6 tasks
@josemaia josemaia deleted the patch-1 branch October 21, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemaia @CLAassistant @JStickler