docs: Update docs for structured metadata blooms #14555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bloom compactor component has been removed in favor of the bloom planner/builder/gateway, none of which use hash rings.
Replace references to bloom compactor with the new bloom planner and bloom builder components.
github-actions
bot
added
the
type/docs
Update the Query Acceleration with Blooms topic to reference structured metadata blooms over the removed line blooms. Documentation on how to configure bloom components has been temporarily removed while the architecture is still under active changes.
rfratto
force-pushed
the
docs-structured-metadata-blooms
branch
from
6c94ad6
to
0117f2b
Compare
chaudum
approved these changes
Oct 21, 2024
JStickler
reviewed
Oct 21, 2024
rfratto
force-pushed
the
docs-structured-metadata-blooms
branch
from
a8acc16
to
4561c6f
Compare
Co-authored-by: J Stickler <julie.stickler@grafana.com>
JStickler
approved these changes
Oct 24, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
|
Oh, one last thing, do we need to backport this to any of the branches, for example does this need to be published to 3.2? Or is this just going into the "next" release? |
Good question, I'm pretty sure that all of our bloom changes weren't backported to 3.2, so I think keeping this in next is the right move. cc @salvacorts @chaudum for final confirmation (I'll backport after merging if necessary) |
rfratto
force-pushed
the
docs-structured-metadata-blooms
branch
from
cbb8bc8
to
83d7929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Documentation for how to configure the new bloom components has been temporarily removed as we are still actively making changes to the architecture.
Which issue(s) this PR fixes:
Closes #14414
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR