feat(loki): include structured_metadata size while asserting rate limit #14571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it and into `loki_distributor_discarded_bytes` metric. Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
…n-discarded-bytes
vlad-diachenko
changed the title
loki_distributor_discarded_bytes metricSigned-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
github-actions
bot
added
the
type/docs
JStickler
reviewed
Oct 22, 2024
salvacorts
reviewed
Oct 22, 2024
…ed metadata size Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
…n-discarded-bytes
salvacorts
approved these changes
Oct 23, 2024
…uture metadata size because it's injected on distributors' size(for most of the cases). Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
…n-discarded-bytes
I have verified that the fix works as expected: |
vlad-diachenko
deleted the
vlad.diachenko/include-structured-metadata-in-discarded-bytes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Include structured_metadata size while asserting rate limit and into
loki_distributor_discarded_bytesmetric.This change is required because OTEL logs use
structured_metadatamore aggressively, and the size of it can be even bigger than the size of the log line.Also, when the write path is blocked(feature implemented in this PR), the amount of ingested data must be equal to discarded data amount with the reason
blocked_ingestion. Before this PR, it was not true, because the metricloki_distributor_bytes_received_totalincluded structured_metadata size butloki_distributor_discarded_bytesdid not.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR