Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix Slack URL #14599

Merged
merged 1 commit into from
Oct 24, 2024
Merged

docs: Fix Slack URL #14599

merged 1 commit into from
Oct 24, 2024

Conversation

SeamusGrafana
Copy link
Contributor

@SeamusGrafana SeamusGrafana commented Oct 24, 2024 •
edited
Loading

What this PR does / why we need it:

Fixes Slack URL Markdown Formatting

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@SeamusGrafana SeamusGrafana requested a review from a team as a code owner October 24, 2024 08:33
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 24, 2024
ashwanthgoli
ashwanthgoli approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit 8361cf2 into main Oct 24, 2024
63 checks passed
@ashwanthgoli ashwanthgoli deleted the SeamusGrafana-patch-1 branch October 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

Assignees
No one assigned
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeamusGrafana @ashwanthgoli