chore(storage/bloom): support simplifiable regexp matchers #14622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for basic regexps which can be simplified into a sequence of OR matchers, such as: * `key=~"value"` becomes `key="value"` * `key=~"value1|value2"` becomes `key="value1" or key="value2"`. Matchers like `key=~".+"` continue to not be supported because the lack of a key doesn't mean that it doesn't exist as a label. Only the cases above are "officially" supported. However, we technically support basic concatenations and character classes due to how regexp/syntax parses and simplifies expressions such as `value1|value2` into `value[12]`. To prevent unbounded cardinality, we limit regexp expansion to 25 matchers; otherwise a regexp like `value[0-9][0-9][0-9][0-9]` would expand into 10,000 matchers (too many!).
github-actions
bot
added
the
type/docs
JStickler
reviewed
Oct 25, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
chaudum
reviewed
Nov 4, 2024
salvacorts
reviewed
Nov 4, 2024
rfratto
force-pushed
the
bloom-support-simplifiable-regexp
branch
from
2fb1a06 to
f7df523
Compare
|
@salvacorts Going to merge since you gave a soft LGTM in your last review, but please let me know if there's any other changes you'd like me to make :) |
chaudum
pushed a commit
that referenced
this pull request
Nov 6, 2024
This adds support for basic regexps which can be simplified into a sequence of OR matchers, such as: * `key=~"value" becomes key="value" * `key=~"value1|value2" becomes key="value1" or key="value2". * `key=~".+" checks for the presence of key. This is currently the only way to check if a key exists. Only the cases above are "officially" supported. However, we technically support basic concatenations and character classes due to how regexp/syntax parses and simplifies expressions such as `value1|value2` into `value[12]`. To prevent unbounded cardinality, we limit regexp expansion to 25 matchers; otherwise a regexp like `value[0-9][0-9][0-9][0-9]` would expand into 10,000 matchers (too many!). Closes grafana/loki-private#1106. Co-authored-by: J Stickler <julie.stickler@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds support for basic regexps which can be simplified into a sequence of OR matchers, such as:
key=~"value"becomeskey="value"key=~"value1|value2"becomeskey="value1" or key="value2".key=~".+"checks for the presence ofkey.key=~".+"is currently the only way to check if a key exists.Only the cases above are "officially" supported. However, we technically support basic concatenations and character classes due to how regexp/syntax parses and simplifies expressions such as
value1|value2intovalue[12].To prevent unbounded cardinality, we limit regexp expansion to 25 matchers; otherwise a regexp like
value[0-9][0-9][0-9][0-9]would expand into 10,000 matchers (too many!).Which issue(s) this PR fixes:
Closes grafana/loki-private#1106.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR