Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tenant limits as dependency to pattern ingester #14665

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

The overrides module may not be initialized when we init the pattern ingester. As a result, we can see some panics when we try to get the list of json fields to mine patterns from.

This PR fixes the issue by adding the overrides dependency to the pattern ingester module.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts requested a review from a team as a code owner October 30, 2024 13:20
@na-- na-- merged commit 31eea90 into main Oct 30, 2024
61 checks passed
@na-- na-- deleted the salvacorts/fix-drain-json-limits branch October 30, 2024 13:27
@na-- na-- added type/bug Somehing is not working as expected backport k226 labels Oct 30, 2024
loki-gh-app bot pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k226 size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants