Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move partition_id into label to make PromQL easier #14714

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Nov 1, 2024

What this PR does / why we need it:

Moves the partition_id from the value to a label to make PromQL counts easier.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner November 1, 2024 11:57
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-gauge-for-partition-id branch from 6de6017 to cf2b5c3 Compare November 1, 2024 14:12
@grobinson-grafana grobinson-grafana merged commit e6cf423 into main Nov 1, 2024
59 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-gauge-for-partition-id branch November 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants