Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TSDB): add hooks for in-memory only tsdb creation #14734

Merged
merged 14 commits into from
Nov 4, 2024
Merged

chore(TSDB): add hooks for in-memory only tsdb creation #14734

merged 14 commits into from
Nov 4, 2024

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Nov 1, 2024 •
edited
Loading

followup to #14732, lets tsdb builder use the new memory-backed index creation.

# ensures pre-refactor and post-refactor TSDBs are the same
$ cmp old new
# ensures TSDBs created in memory are equivalent to those created with disk
$ cmp new mem

owen-d added 13 commits October 30, 2024 17:03
@owen-d
filewriter refactoring prep: remove external use of private field
1c596de 
ReaderFrom & Writer impl
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
new writer file
13047c4 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
rename index.Writer -> index.Creator + adds new writer ifc
9d34fcd 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
writer ifc, small updates
258bf5f 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
uses writer, removes mmap from tsdb writing
fddadda 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
mem writer
39f840f 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
memwriter
eda270c 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
tsdb creator can optionally return the io.ReadCloser of its bytes
427505d 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
make format
9cfd271 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
signature fixup
9af4e07 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
lint
941cdcb 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
entrypoints for writing tsdb w/ file system (current) and memory (fut…
0db3f34 
…ure)

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
BuildInMemory TSDB hook
c970b07 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner November 1, 2024 20:29
@owen-d owen-d changed the title enhancement(TSDB): add hooks for in-memory only tsdb creation chore(TSDB): add hooks for in-memory only tsdb creation Nov 1, 2024
cyriltovena
cyriltovena approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d
Merge remote-tracking branch 'upstream/main' into tsdb/use-mem-writer
eaf6077 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Nov 4, 2024
@owen-d owen-d merged commit 1c993f9 into grafana:main Nov 4, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @cyriltovena