chore: Fix regression in bloom gateway that caused nothing to be filtered #14807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvacorts
approved these changes
Nov 7, 2024
| result = &logproto.GetChunkRefResponse{ | ||
| Refs: make([]*logproto.ChunkRef, 0, len(chunks)), | ||
| } | ||
| for _, cs := range chunks { | ||
| for i := range cs { | ||
| result.Refs = append(result.Refs, &cs[i].ChunkRef) | ||
| if _, ok := series[cs[i].Fingerprint]; !ok { | ||
| series[cs[i].Fingerprint] = cs[i].Metric |
There was a problem hiding this comment.
nit: What about adding a comment in the chunk struct about fields not being populated until fetched?
There was a problem hiding this comment.
^ I would also like this, it seems inevitable that someone is going to run into this again since it's not very obvious.
Pull request #14661 added the series labels to the FilterChunkRefs request in order to be able to filter out full series that do not contain the filter key when using bloom filters. However, this chage incorrectly assumed that `Chunk.Metric` from the `GetChunks()` call contains the labels of the stream. This information is only populated once the chunk is fetched, though. Therefore the list of labels was empty, and no chunk refs were filtered. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/fix-get-series
branch
from
17a4ca5 to
5a0c481
Compare
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
loki-gh-app bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
…ered (#14807) Pull request #14661 added the series labels to the `FilterChunkRefs` request in order to be able to filter out full series that do not contain the filter key when using bloom filters. However, this change incorrectly assumed that `Chunk.Metric` from the `GetChunks()` call contains the labels of the stream. This information is only populated once the chunk is fetched, though. Therefore the list of labels was empty, and no chunk refs were filtered. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 3b20cb0)
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pull request #14661 added the series labels to the
FilterChunkRefsrequest in order to be able to filter out full series that do not contain the filter key when using bloom filters.However, this change incorrectly assumed that
Chunk.Metricfrom theGetChunks()call contains the labels of the stream. This information is only populated once the chunk is fetched, though. Therefore the list of labels was empty, and no chunk refs were filtered.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR