Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Skip multi-tenant TSDBs during bloom planning (backport k227) #14888

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(blooms): Skip multi-tenant TSDBs during bloom planning (backport k227) #14888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/bloombuild/planner/planner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ func (p *Planner) computeTasks(
// Resolve TSDBs
tsdbs, err := p.tsdbStore.ResolveTSDBs(ctx, table, tenant)
if err != nil {
level.Error(logger).Log("msg", "failed to resolve tsdbs", "err", err)
return nil, nil, fmt.Errorf("failed to resolve tsdbs: %w", err)
}

Expand Down Expand Up @@ -664,9 +663,14 @@ func (p *Planner) loadTenantTables(
}

for tenants.Next() && tenants.Err() == nil && ctx.Err() == nil {
p.metrics.tenantsDiscovered.Inc()
tenant := tenants.At()
if tenant == "" {
// Tables that have not been fully compacted yet will have multi-tenant TSDBs for which the tenant is ""
// in this case we just skip the tenant
continue
}

p.metrics.tenantsDiscovered.Inc()
if !p.limits.BloomCreationEnabled(tenant) {
level.Debug(p.logger).Log("msg", "bloom creation disabled for tenant", "tenant", tenant)
continue
Expand Down
Loading