Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove minor dead code that was missed in a PR review #15094

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

cstyan
Copy link
Contributor

@cstyan cstyan commented Nov 25, 2024

offsetsBuf wasn't actually being used anywhere, looks like this just got missed in a refactor commit as part of #13983
cc @MasslessParticle @ashwanthgoli

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan cstyan requested a review from a team as a code owner November 25, 2024 03:24
@cstyan cstyan changed the title remove minor dead code that was missed in a PR review chore: remove minor dead code that was missed in a PR review Nov 25, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit 1ea49e3 into main Nov 25, 2024
60 checks passed
@ashwanthgoli ashwanthgoli deleted the pipeline-dead-code-20241124 branch November 25, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants