Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect error check in autoCommitLoop #15149

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: incorrect error check in autoCommitLoop #15149

merged 1 commit into from
Nov 27, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Nov 27, 2024 •
edited
Loading

What this PR does / why we need it:

This commit fixes an incorrect error check in autoCommitLoop.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner November 27, 2024 12:42
@grobinson-grafana grobinson-grafana force-pushed the grobinson/fix-error-check branch from 17b5b6a to 65e0b6f Compare November 27, 2024 12:46
cyriltovena
cyriltovena approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grobinson-grafana grobinson-grafana merged commit 4b5925a into main Nov 27, 2024
60 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-error-check branch November 27, 2024 12:55
This was referenced Dec 23, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grobinson-grafana @cyriltovena