-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added mount to docker-driver config #1555
Conversation
As I'm not sufficient good in Go - I ve just proposed this change |
Can you explain how to use this ? I think I have an idea but I would like to see what was your plan. |
currently I need to do this trick while deploying my app with docker
It would be better to specify visible folders for plugin in env configuration scripts. for example workspace folder path of an app.
|
how can it be empty ? where will you put your file after ? I think this need a bit of documentation. |
for file on my local env /folder/sub/pipeline.yml
and then I'll set
|
Yeah I think this is good, I would like a bit of documentation on the usage in the PR if you don't mind. |
Ok, I'll take time to generate details in the PR |
That would be great to do a step by step on how to mount the config.
a new chapter here https://github.com/grafana/loki/blob/master/docs/clients/docker-driver/configuration.md |
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
related to:
#694
#700
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist