chore: clone the context instead of using background context while pushing logs to ingesters from distributor #15735
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We use background context to push logs to Ingesters from Distributors to continue to ingest logs when we return early. This is to avoid stopping ingestion to remaining ingesters after hitting quorum. However, we have to explicitly copy the required context keys from the parent to the newly created context.
I am working on some changes that add a new key to the context, and I feel that copying all the required keys is cumbersome and error-prone. What we want here is a clone of context without cancellation propagation from parent to child. This is now achievable using context.WithoutCancel.