chore(dataobj): add logs tracking and encoding #15757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is the equivalent of grafana#15713 for the logs section: log records are accumulated into column builders and then flushed into a section at encoding time. Some minor API changes have been made to sections/streams to ensure consistency with sections/logs.
benclive
approved these changes
Jan 15, 2025
| if err := streamsEnc.Commit(); err != nil { | ||
| return err | ||
| } | ||
| s.Reset() |
There was a problem hiding this comment.
There's no need to reset if we error? In the error case, would we just abort completely and not re-use this object?
There was a problem hiding this comment.
I think I was originally considering intermittent errors, but you're right; that shouldn't happen from the caller's perspective. I'll have it reset always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the equivalent of #15713 for the logs section: log records are accumulated into column builders and then flushed into a section at encoding time.
Some minor API changes have been made to sections/streams to ensure consistency with sections/logs.