cache key cant be reused when an interval changes #1616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes a small (and probably unrealistic) loophole in the cache key generation code for the result cache. Including the interval used in a cache key will prevent us from ever reusing the same key across
querier.split-queries-by-interval
(and associated overrides) configuration changes.For a hypothetical request start value 12 and split intervals 5 and 6, we'd generate the same cache keys because
12/5
==12/6
in integer division. We now include the5
and6
respectively in our cache keys to prevent this collision.Checklist