Support entire extracted value map in template pipeline stage #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityacs
force-pushed
the
1559
branch
4 times, most recently
from
202b2c1 to
6354f48
Compare
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
==========================================
+ Coverage 62.56% 62.57% +0.01%
==========================================
Files 112 112
Lines 8615 8607 -8
==========================================
- Hits 5390 5386 -4
+ Misses 2822 2818 -4
Partials 403 403
|
cyriltovena
reviewed
Feb 10, 2020
cyriltovena
reviewed
Feb 10, 2020
adityacs
commented
Feb 11, 2020
cyriltovena
reviewed
Feb 11, 2020
adityacs
commented
Feb 12, 2020
adityacs
force-pushed
the
1559
branch
5 times, most recently
from
297ab01 to
b5d636b
Compare
adityacs
commented
Feb 12, 2020
cyriltovena
reviewed
Feb 12, 2020
cyriltovena
reviewed
Feb 12, 2020
adityacs
force-pushed
the
1559
branch
2 times, most recently
from
2b91ebf to
4bca034
Compare
cyriltovena
reviewed
Feb 13, 2020
Refactor template stage processing. This sets all extracted key available, plus if the source is available adds the extra key `Value` for backward compatibility. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Signed-off-by: Aditya C S <aditya.gnu@gmail.com>
cyriltovena
reviewed
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Supports templating with multiple keys in template pipeline stage
Which issue(s) this PR fixes:
Fixes #1559
Checklist