Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix promtail/templates/NOTES.txt to show correctly port-forward command #1697

Merged
merged 2 commits into from
Feb 14, 2020
Merged

fix promtail/templates/NOTES.txt to show correctly port-forward command #1697

merged 2 commits into from
Feb 14, 2020

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Feb 14, 2020

What this PR does / why we need it:
When loki/promtail is installed, it shows invalid notes.
2 commands (kubectl, curl) are missing a port.

Which issue(s) this PR fixes:
Fixes #1696

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-io
Copy link

Codecov Report

Merging #1697 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
- Coverage   63.13%   63.05%   -0.08%     
==========================================
  Files         120      120              
  Lines        8909     8909              
==========================================
- Hits         5625     5618       -7     
- Misses       2867     2871       +4     
- Partials      417      420       +3
Impacted Files Coverage Δ
pkg/promtail/targets/tailer.go 73.56% <0%> (-4.6%) ⬇️
pkg/promtail/targets/filetarget.go 68.71% <0%> (-1.85%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks !

@cyriltovena cyriltovena merged commit 92ec0e5 into grafana:master Feb 14, 2020
@oke-py oke-py deleted the helm-promtail branch February 14, 2020 22:16
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Use human-readable names for chunk encodings
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
…nd (grafana#1697)

Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loki/promtail Helm Chart shows invalid notes
3 participants