Promtail: Ignore dropped entries in subsequent metric-stages in pipelines. #1743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the
metric
stage in Promtail ignore dropped entries.This allows users to define a pipeline like this:
In general this also fixes the issue were the above config today would generate an error message like this:
Which issue(s) this PR fixes:
Doesn't fix a GH-Issue 😢
Special notes for your reviewer:
I also have a branch
feature/metrics-on-dropped
that solves this issue by removing labels with the prefix__
instead. But I do believe that this PR solves the problem in a more predictable way.Checklist