Skip to content

fix(ksonnet): index-gateway make overrides configmap as var and antiAffinity #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sentoz
Copy link
Contributor

@sentoz sentoz commented May 28, 2025

fix(ksonnet): index-gateway make overrides configmap names and mount path as variables and antiAffinity

What this PR does / why we need it:

Fixes the problem that by specifying the variables _config.overrides_configmap_mount_name and
_config.overrides_configmap_mount_path, the name and path of the overrides configmap did not change.
And fixes the problem of not adding antiAffinity

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@sentoz sentoz requested a review from a team as a code owner May 28, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant