Loki/Change local storage directory to /loki/ and fix permissions (#1833) #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mario-Hofstaetter
force-pushed
the
directory-permissions
branch
from
4851c66 to
7af2704
Compare
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
+ Coverage 64.82% 64.83% +0.01%
==========================================
Files 122 122
Lines 9237 9237
==========================================
+ Hits 5988 5989 +1
+ Misses 2834 2833 -1
Partials 415 415
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The default persistent directory
/tmp/loki/inlocal-config.yamlcannot be a named docker volume because of permissions issues (see #1833)Directory changed to
/loki/and set permissions forloki:lokiWhich issue(s) this PR fixes:
Fixes #1833
Special notes for your reviewer:
Checklist