Addition of a /suspend endpoint to Loki Canary
#1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
changed the title
/suspend endpoint to Loki Canary
|
thoughts on adding k8s folks can kill the pod but more people are using this now standalone and a |
|
Good idea. Looking into it! |
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
|
cyriltovena
reviewed
Apr 3, 2020
cyriltovena
reviewed
Apr 3, 2020
| w := writer.NewWriter(os.Stdout, sentChan, *interval, *size) | ||
| r := reader.NewReader(os.Stderr, receivedChan, *tls, *addr, *user, *pass, *lName, *lVal) | ||
| c := comparator.NewComparator(os.Stderr, *wait, *pruneInterval, *buckets, sentChan, receivedChan, r, true) | ||
| c := &canary{} |
There was a problem hiding this comment.
you could make start a function of c too no ? like stop ?
There was a problem hiding this comment.
I was considering it but decided against it b/c it would have to take like 10 parameters. This seemed less gross.
cyriltovena
approved these changes
Apr 3, 2020
Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a suspend endpoint to accomodate a way to permanently stop a canary without killing the process. Canary now honors SIGINT as expected.
Which issue(s) this PR fixes:
Fixes #1700
Special notes for your reviewer:
Checklist