Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix promtail client default values #2049

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

adityacs
Copy link
Contributor

@adityacs adityacs commented May 6, 2020

What this PR does / why we need it:
Fix promtail client default values

/cc @slim-bean

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@cyriltovena cyriltovena merged commit 83873d1 into grafana:master May 8, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…ject stores (grafana#2049)

* support for registering custom index clients, added new methods to object store

NewIndexClient accepts factory methods for creating custom index clients
added new methods to object stores to work on objects(io.Reader) instead of just chunks

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* splitted s3 config from dynamodb config and updated docs

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* removed unwanted code

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* added List method to azure and addressed other feedback in PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* addressed some of the feedback from PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* changes suggested from PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* fixed an issue with reporting errors in PutObject for GCS object store

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants