Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds backtick for the quoted string token lexer. #2095

Merged
merged 4 commits into from
May 19, 2020
Merged

Adds backtick for the quoted string token lexer. #2095

merged 4 commits into from
May 19, 2020

Commits on May 19, 2020

  1. Fixes unit in stats request log. (grafana#2093) 

    * Fix unit conversion in stats log.

🤦

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Fix the tests because you know ! you know ?

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

wip

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed May 19, 2020
    Configuration menu
    Copy the full SHA
    bd2bba6 View commit details
    Browse the repository at this point in the history

  2. Add backtick for the quoted string token lexer. 

    This allows to pass unescaped string to Loki.

For example we now support this :

`` {name="cassandra"} |~  `error=\w+` ``
`` {name!~`mysql-\d+`} ``

As you can see no escape is required when using ` quoted strings.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed May 19, 2020
    Configuration menu
    Copy the full SHA
    8e6b0a2 View commit details
    Browse the repository at this point in the history

  3. Fixes newlines. 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed May 19, 2020
    Configuration menu
    Copy the full SHA
    3a81a17 View commit details
    Browse the repository at this point in the history

  4. Add back missing test. 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed May 19, 2020
    Configuration menu
    Copy the full SHA
    bbce678 View commit details
    Browse the repository at this point in the history