Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluentd plugin #210

Merged
merged 5 commits into from
Jan 17, 2019
Merged

Fluentd plugin #210

merged 5 commits into from
Jan 17, 2019

Conversation

woodsaj
Copy link
Member

@woodsaj woodsaj commented Jan 10, 2019

This is the initial release of a Fluentd output plugin for Loki.

woodsaj and others added 3 commits December 31, 2018 18:21
add beginnings of fluentd plugin
7abfc00
@briangann
working fluentd output plugin for loki
63648ed
refactor fluentd plugin
f216776 
- update the plugin to support extra_labels, label_keys, line_format
  and drop_single_key options
- update rspec tests
- update readme
- build custom docker image for docker-compose
- default to systemd input by default.
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tomwilkie
Copy link
Contributor

Gonna assume both @briangann and @woodsaj approved this...

@tomwilkie
Copy link
Contributor

Gonna assume both @briangann and @woodsaj approved this...

@tomwilkie
Copy link
Contributor

AFAICT all the files are in fluentd/fluent-plugin-loki/ - do we need both directories?

briangann
briangann approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two things to update - removing the license file and updating the readme

fluentd/fluent-plugin-loki/README.md Outdated Show resolved Hide resolved
@woodsaj
Copy link
Member Author

woodsaj commented Jan 11, 2019

AFAICT all the files are in fluentd/fluent-plugin-loki/ - do we need both directories?

The only reason for having the top level fluentd dir is to allow as adding additional plugins. Though if they are loki specific then the convention is to put them in fluent-plugin-loki/lib/fluent/plugin so we could have "out_loki.rb", "filter_loki.rb", etc....
If the plugins are useful for Loki, but not Loki specific, eg an input plugin for k8s pods, then they should probably live in their own repo anyway.

@tomwilkie tomwilkie merged commit 880725f into master Jan 17, 2019
@tomwilkie tomwilkie deleted the fluentd branch January 17, 2019 11:28
@jgsqware
Copy link

jgsqware commented Feb 4, 2019

Doest the image with Fluentd-loki plugin is available on docker hub?

what about this plugin https://github.com/eeddaann/fluent-plugin-loki ?

This was referenced Feb 18, 2019
Closed
Closed
@markuman markuman mentioned this pull request May 1, 2019
Closed
periklis added a commit to periklis/loki that referenced this pull request Dec 7, 2023
@periklis
Merge pull request grafana#210 from grafana/main
67a9312 
Update from upstream repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangann briangann briangann approved these changes

@tomwilkie tomwilkie tomwilkie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@woodsaj @CLAassistant @tomwilkie @jgsqware @briangann