Update go-syslog to accept non-UTF8 encoding in syslog message #2127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Related to influxdata/go-syslog#35.
Stops
promtail
from dropping syslog connections if the message does contain characters in a non-UTF8 encoding. RFC5424 explicitly allows non-UTF8 messages.File target passes non-UTF8 text as-is too.
Which issue(s) this PR fixes:
Fixes #1783
Special notes for your reviewer:
Casting to
*rfc5424.SyslogMessage
is now necessary since since go-syslog could now support rfc3164 (BSD syslog) if enabled.Checklist