Logql comparison ops #2182
Merged
Logql comparison ops #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
force-pushed
the
logql-comparison-ops
branch
from
b82336f to
3efcfe3
Compare
cyriltovena
reviewed
Jun 5, 2020
| @@ -1207,6 +1304,54 @@ func TestEngine_RangeQuery(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| `bytes_over_time({app="foo"}[30s]) > bool 1`, time.Unix(60, 0), time.Unix(120, 0), 15 * time.Second, 0, logproto.FORWARD, 10, | |||
There was a problem hiding this comment.
hahahaha this is so cool.
I can already see someone doing alert because he doesn't want to log too much.
/cc @slim-bean
cyriltovena
reviewed
Jun 5, 2020
| // cannot compare metric & log queries | ||
| in: `count_over_time({ foo != "bar" }[12m]) > { foo = "bar" }`, | ||
| err: ParseError{ | ||
| msg: "unexpected type for right leg of binary operation (>): *logql.matchersExpr", |
cyriltovena
reviewed
Jun 5, 2020
| @@ -645,7 +645,7 @@ func TestMapping(t *testing.T) { | |||
| in: `1 + sum by (cluster) (rate({foo="bar"}[5m]))`, | |||
| expr: &binOpExpr{ | |||
| op: OpTypeAdd, | |||
| SampleExpr: &literalExpr{1}, | |||
| SampleExpr: &literalExpr{value: 1}, | |||
cyriltovena
approved these changes
Jun 5, 2020
|
Nice!!! This was quick @owen-d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comparison operators:
Comparison operators
==(equality)!=(inequality)>(greater than)>=(greater than or equal to)<(less than)<=(less than or equal to)Comparison operators are defined between scalar/scalar, vector/scalar, and vector/vector value pairs. By default they filter. Their behavior can be modified by providing bool after the operator, which will return 0 or 1 for the value rather than filtering.
Between two scalars, the bool modifier must be provided and these operators result in another scalar that is either 0 (false) or 1 (true), depending on the comparison result.
1 >= 1is equivalent to1Between a vector and a scalar, these operators are applied to the value of every data sample in the vector, and vector elements between which the comparison result is false get dropped from the result vector. If the bool modifier is provided, vector elements that would be dropped instead have the value 0 and vector elements that would be kept have the value 1.
count_over_time({foo="bar"}[1m]) > 10Filters the streams which log at elast 10 lines in the last minute.count_over_time({foo="bar"}[1m]) > bool 10The same as above, but instead of filtering, attached the value 0 to streams that log less than 10 lines.Between two vectors, these operators behave as a filter by default, applied to matching entries. Vector elements for which the expression is not true or which do not find a match on the other side of the expression get dropped from the result, while the others are propagated into a result vector. If the bool modifier is provided, vector elements that would have been dropped instead have the value 0 and vector elements that would be kept have the value 1, with the grouping labels again becoming the output label set.
sum without(app) (count_over_time({app="foo"}[1m])) > sum without(app) (count_over_time({app="bar"}[1m]))Returns the streams matchingapp=foowithout app labels that have higher counts within the last minute than their counterparts matchingapp=barwithout app labels.sum without(app) (count_over_time({app="foo"}[1m])) > bool sum without(app) (count_over_time({app="bar"}[1m]))The same as above, but vectors have their values set to 1 if they pass the comparison or 0 if they fail/would otherwise have been filtered out./cc @cyriltovena
I'd appreciate if you can think of ways to simplify this.