Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoids recording stats in the sharded engine #2249

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jun 22, 2020

This avoids recording stats in the sharded engine as it's executed in every split of the query frontend. The frontend uses an explicit middleware to extract/record the aggregate stats.

/cc @cyriltovena

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2249 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2249      +/-   ##
==========================================
- Coverage   62.34%   62.27%   -0.07%     
==========================================
  Files         158      158              
  Lines       12760    12761       +1     
==========================================
- Hits         7955     7947       -8     
- Misses       4193     4198       +5     
- Partials      612      616       +4     
Impacted Files Coverage Δ
pkg/logql/engine.go 90.38% <100.00%> (+0.06%) ⬆️
pkg/promtail/targets/tailer.go 73.86% <0.00%> (-4.55%) ⬇️
pkg/promtail/targets/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️
pkg/logql/evaluator.go 92.13% <0.00%> (-0.41%) ⬇️

@owen-d owen-d merged commit 15378cf into grafana:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants